Crash of the application : line alone inside a group

google / automotive-design-compose

Automotive Design for Compose is an extension to Jetpack Compose that allows every screen, component, and overlay of your Android App to be defined in Figma, and lets you see the latest changes to your Figma design in your app, immediately!

https://google.github.io/automotive-design-compose/

Apache License 2.0

116 stars 17 forks source link

Crash of the application : line alone inside a group #289

Open elouannf opened 1 year ago

elouannf commented 1 year ago

A crash occur when I am adding a line without any rotation alone inside a group. It might be due to the fact that a group has a height of 0. This makes the application crash and I have to delete the figma file (saved) inside the emulator.

rizniazi commented 1 year ago

We are trying to repro, will update on the findings.

timothyfroehlich commented 1 year ago

Hi @elouannf , sorry for taking so long to get to this. I've tried reproducing this, but I can't get a group to have a size of less than 1. Could you share a Figma file that reproduces the crash?

timothyfroehlich commented 1 year ago

Putting this on the back burner, let me know if you can reproduce and we'll take a look at it again.

elouannf commented 1 year ago

Hi @timothyfroehlich, Here is an example were my app used to crash. In this group the height is 0 for the group

timothyfroehlich commented 1 year ago

I managed to get the group size to 0 (had to set the line's inclination to 0) but I'm still not seeing a crash with DesignCompose 0.21, 0.22 or 0.23. Here's the figma file I used: Untitled.fig.zip

Could you upload a full reproduction? If you can send me a full Android Studio project as well as an export of the actual Figma file then that should be everything I need to reproduce it.

The Android Studio project would be something like our Tutorial project. Don't forget to remove any build files before you send it. And you can export the Figma file from Figma by opening the main menu, clicking File and selecting "Save local copy", like this: