google / automotive-design-compose

Automotive Design for Compose is an extension to Jetpack Compose that allows every screen, component, and overlay of your Android App to be defined in Figma, and lets you see the latest changes to your Figma design in your app, immediately!
https://google.github.io/automotive-design-compose/
Apache License 2.0
112 stars 16 forks source link

MediaCompose incompatible with latest Unbundled release - 20240314 #952

Closed timothyfroehlich closed 2 weeks ago

timothyfroehlich commented 6 months ago

As reported by Yiqun, MediaCompose can no longer compile with the latest Unbundled release. car-media-extensions seems to be missing.

* What went wrong:
Could not determine the dependencies of task ':mediacompose-app:processDebugResources'.
> Could not resolve all task dependencies for configuration ':mediacompose-app:debugRuntimeClasspath'.
   > Could not find AAOS Apps:car-media-extensions:unspecified.
     Required by:
         project :mediacompose-app > project :media-lib > com.android.car:car-media-common:UNBUNDLED

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 4s
25 actionable tasks: 4 executed, 21 up-to-date
Configuration cache entry stored.
timothyfroehlich commented 6 months ago

Digging in:

timothyfroehlich commented 5 months ago

@yiqunw700 The new car-media-extensions library will need some Gradle configuration applied to it. The change will be made in car-apps-dev. I'll make and submit that change, and then we'll have to wait for that change to be included in a release of ub-automotive-master. So your fixes won't work until that release is made.

So what you should do is to get things working against car-apps-dev. Once you get it working there you can upload the PR here. The presubmits will fail and that's fine, we'll just let it sit until the fixes in car-apps-dev land in ub-automotive-master and merge it then.

I'll link the change for car-apps-dev once I have it ready (today or tomorrow).

timothyfroehlich commented 5 months ago

@yiqunw700 ag/27085619 has been created which adds the missing publishing configuration for car-media-extensions and a new library that seems to have been added since the last public release.

I have uploaded a branch named wb/froeht/fix-mediacompose which fixes the issue with android.car.media.CarMediaManager that I described in my second comment

You should be able to use those changes to work on fixing the other three issues. I would suggest copying the change in wb/froeht/fix-mediacompose into your own branch.

yiqunw700 commented 2 weeks ago

1051 should have fixed this. I might forget to close it.