Closed zxzxwu closed 1 year ago
We need something that works for non-async
tests as well, using a thread or a signal ? :thinking:
Or we can add something like this in the setup_test
?
import signal
def setup_test(self) -> None:
signal.signal(signal.SIGALRM, lambda _signum, _frame: raise TimeoutError("test timed out"))
signal.alarm(30)
Could we instead set a default deadline on GRPC calls ?
Could we instead set a default deadline on GRPC calls ?
It's also a solution, but I didn't find any global timeout/deadline configuration. Or we may manually add timeout to each call, and setup some lint there.
We can also change the gRPC code generator, but it's a radical solution
And on server side ?
And on server side ?
The safest way is to do on the both side and select the shorter one, but if we must pick one, client side is safer because
Rebase on https://github.com/google/avatar/pull/58
WDYT on using literals directly without any forwarded constant ?
WDYT on using literals directly without any forwarded constant ?
That's a good idea. I moved them into an user param.
Current
ConnectLE()
andScan()
methods miss a native timeout condition, so timeout must be set explicitly to avoid halting the tests.