google / bamboo-soy

An intellij plugin supporting Closure Template language (Soy)
Apache License 2.0
48 stars 27 forks source link

xid function should allow alias references. #193

Closed dikmax closed 4 years ago

dikmax commented 4 years ago

Consider following code:

{alias some.package.AwesomeController}

{template .render}
  <div jscontroller="{xid(AwesomeController)}"></div>
{/template}

which is valid, but now plugin shows parsing error:SoyTokenType./} or SoyTokenType./} } expected, got 'xid'

BTW, full references like <div jscontroller="{xid(some.package.AwesomeController)}"></div> are parsed as expected.

Tested with plugin version 1.5.0.

crdev commented 4 years ago

Thanks for the report Maxim.

Just to clarify: is this a regression compared to 1.4?

dikmax commented 4 years ago

It's not a regression. It wasn't working before too.