This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Prepare for --incompatible_load_java_rules_from_bzl.
Fixes https://github.com/google/bazel-common/issues/97
Progress toward https://github.com/google/flogger/issues/122
I have also tested this against Flogger and Dagger (modified to fix their own --incompatible_load_java_rules_from_bzl problems). Everything appears to work except for Dagger, which has some breakages from bazel_tools itself, for which I have filed https://github.com/bazelbuild/bazel/issues/10839. (This is in addition to filing and working around https://github.com/bazelbuild/bazel/issues/10838.)
It also includes an upgrade to rules_kotlin to contain the analogous fix for that repo: https://github.com/bazelbuild/rules_kotlin/commit/186c1e1e27d699a8953b75461f2de7c295987cfb
And ditto for protobuf.
50621556258fd64b265f1cf62a9c5fc2d2c1aba1
This code has been reviewed and submitted internally. Feel free to discuss on the PR, and we can submit follow-up changes as necessary.
Commits:
Prepare for --incompatible_load_java_rules_from_bzl. Fixes https://github.com/google/bazel-common/issues/97 Progress toward https://github.com/google/flogger/issues/122 I have also tested this against Flogger and Dagger (modified to fix their own --incompatible_load_java_rules_from_bzl problems). Everything appears to work except for Dagger, which has some breakages from bazel_tools itself, for which I have filed https://github.com/bazelbuild/bazel/issues/10839. (This is in addition to filing and working around https://github.com/bazelbuild/bazel/issues/10838.) It also includes an upgrade to rules_kotlin to contain the analogous fix for that repo: https://github.com/bazelbuild/rules_kotlin/commit/186c1e1e27d699a8953b75461f2de7c295987cfb And ditto for protobuf. 50621556258fd64b265f1cf62a9c5fc2d2c1aba1