google / bazel-common

Common functionality for Google's open-source libraries that are built with bazel.
Apache License 2.0
85 stars 40 forks source link

MOE Sync 2020-06-29 #112

Closed kluever closed 4 years ago

kluever commented 4 years ago

This code has been reviewed and submitted internally. Feel free to discuss on the PR, and we can submit follow-up changes as necessary.

Commits:

Update JavaPoet to 1.13.0 JavaPoet is commonly used in other processors but contained a bug that causes errors in Dagger. This updates the common definition to 1.13.0, which contains a fix for Dagger & Hilt. See https://github.com/google/dagger/issues/1715 and https://github.com/google/dagger/issues/1909 for more context. Closes https://github.com/google/bazel-common/pull/105 0b820e4b1cdc019ce66956c46586ebadba7baad1

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

cpovirk commented 4 years ago

Looks like we got the author line a little wrong when we imported this. I've fixed it:

$ cd some-bazel-common-client
$ git co sync-master-2020/06/29
$ git commit --amend --author="Zac Sweers <pandanomic@gmail.com>" --no-edit
$ git push -f

That put us into the state of "CLAs are signed, but unable to verify author consent." That's our usual state whenever we mirror out changes manually like this, unfortunately. (The switch to Copybara will finally fix this.)

googlebot commented 4 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.