search

google / bazel-common

Common functionality for Google's open-source libraries that are built with bazel.
Apache License 2.0
87 stars 40 forks source link

Update asm to version 9.2 #141

Open gregallen opened 3 years ago

gregallen commented 3 years ago

Need to support java 17

ronshapiro commented 3 years ago

Looks like we're on 9.3 internally - shall we jump straight there?

gregallen commented 3 years ago

yes - that would be great - want this downstream in google allocation instrumenter - see https://github.com/google/allocation-instrumenter/issues/43

amalloy commented 3 years ago

Hey, @ronshapiro. I'm on issue triage this week, and I'm a little confused by your remark about 9.3. AFAICT there's no such thing as 9.3 in maven central (https://mvnrepository.com/artifact/org.ow2.asm/asm), so I'm not sure how we could update to it. Could you explain this further for someone new to updating bazel-common dependencies?

ronshapiro commented 3 years ago

I'm not sure where I saw that to be honest. 9.2 is fine if thats the latest

On Fri, Oct 29, 2021 at 10:58 PM Alan Malloy @.***> wrote:

Hey, @ronshapiro https://github.com/ronshapiro. I'm on issue triage this week, and I'm a little confused by your remark about 9.3. AFAICT there's no such thing as 9.3 in maven central ( https://mvnrepository.com/artifact/org.ow2.asm/asm), so I'm not sure how we could update to it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/bazel-common/issues/141#issuecomment-955013172, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGBRXP6272ML6HU4XYR7SLUJL4E3ANCNFSM5GNWFR4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

gregallen commented 2 years ago

@amalloy any chance this update could be done? I see there is a new update script to help

gregallen commented 2 years ago

@ronshapiro @amalloy any chance you could help to progress this? thanks!

ronshapiro commented 2 years ago

Sorry I kept losing track of this. Just opened a commit internally