google / bazel-common

Common functionality for Google's open-source libraries that are built with bazel.
Apache License 2.0
87 stars 40 forks source link

Rename @maven -> @google_bazel_common_maven #198

Closed lamcw closed 1 month ago

lamcw commented 1 month ago

Non-root modules should not use maven as the name of maven closure as it can create duplicate artifacts/conflicts with other closure (and most importantly the closure created in the root module) -- see https://github.com/bazel-contrib/rules_jvm_external/issues/916.

This PR creates a custom namespace for maven jars that is used within google_bazel_common, following similar patterns in

lamcw commented 1 month ago

@netdpb what else do I need to do to get this merged?

netdpb commented 1 month ago

@netdpb what else do I need to do to get this merged?

Nothing. We had to go through our internal merge process. Thanks for your work!