search

google / bazel-common

Common functionality for Google's open-source libraries that are built with bazel.
Apache License 2.0
84 stars 42 forks source link

Consider using google/jarjar instead of pantsbuild/jarjar #21

Open cushon opened 6 years ago

cushon commented 6 years ago

Bazel itself uses https://github.com/google/jarjar. It's actually distributed with Bazel as @bazel_tools//third_party/java/jarjar:jarjar_import, although you may not want to depend on those labels for bazel-common.

ronshapiro commented 6 years ago

That actually sounds good - the pantsbuild version says that it isn't meant to be used anywhere outside of pants. Fewer external dependencies to manage

On Thu, May 24, 2018, 6:37 PM Liam Miller-Cushon notifications@github.com wrote:

Bazel itself uses https://github.com/google/jarjar. It's actually distributed with Bazel as @bazel_tools//third_party/java/jarjar:jarjar_import, although you may not want to depend on those labels for bazel-common.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/bazel-common/issues/21, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwY3eBhC_74GgCzzAgdS-424s0Lc52dks5t1zYogaJpZM4UNGk1 .

cushon commented 6 years ago

It's distributed with Bazel as @bazel_tools//third_party/java/jarjar:jarjar_import

Er, that's actually the pre-google/jarjar version. The next Bazel release will be using google/jarjar, but at a different label in @bazel_tools//third_party/jarjar instead.

Depending on the repo directly might be more robust than using @bazel_tools.