search

google / bazel-common

Common functionality for Google's open-source libraries that are built with bazel.
Apache License 2.0
86 stars 40 forks source link

Consider adding grpc-proto #54

Open perezd opened 5 years ago

perezd commented 5 years ago

https://github.com/grpc/grpc-proto

This would be hugely useful to be used in conjunction with grpc_java

cpovirk commented 5 years ago

Is that what this is?

https://github.com/google/bazel-common/blob/3ce0644a7d7da09218b96b3218f409ea8f8c84e6/third_party/java/grpc/BUILD#L43 https://github.com/google/bazel-common/blob/3ce0644a7d7da09218b96b3218f409ea8f8c84e6/workspace_defs.bzl#L232

perezd commented 5 years ago

No, specifically it's special protos that grpc uses: https://github.com/grpc/grpc-proto

On Thu, Jul 25, 2019, 8:46 AM Chris Povirk notifications@github.com wrote:

Is that what this is?

https://github.com/google/bazel-common/blob/3ce0644a7d7da09218b96b3218f409ea8f8c84e6/third_party/java/grpc/BUILD#L43

https://github.com/google/bazel-common/blob/3ce0644a7d7da09218b96b3218f409ea8f8c84e6/workspace_defs.bzl#L232

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/bazel-common/issues/54?email_source=notifications&email_token=AAAFA5TY733JXOZZ2V63ASDQBHDETA5CNFSM4GWJKBT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Z4JZI#issuecomment-515097829, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFA5TGVCIPWUXEA4T73NLQBHDETANCNFSM4GWJKBTQ .

cpovirk commented 5 years ago

Ah, sorry, thanks.