Support JavaInfo provider in javadoc_library

google / bazel-common

Common functionality for Google's open-source libraries that are built with bazel.

Apache License 2.0

86 stars 40 forks source link

Support JavaInfo provider in javadoc_library #76

Closed ghost closed 5 years ago

ghost commented 5 years ago

Preparation for https://github.com/bazelbuild/bazel/issues/7598.

Resolves https://github.com/google/bazel-common/issues/75.

Testing Done:

Used javadoc_library in a project with custom Java rules which only export the JavaInfo provider.

ghost commented 5 years ago

@ronshapiro Just a quick follow-up---I'm not super GitHub PR-savvy, so I don't know if there's a preference for fixup commits or squashes, but I force-pushed an amended commit which unrolled the list comprehension. (No worries if you haven't had cycles, but just wasn't sure if GitHub generated a notification or not.)

ronshapiro commented 5 years ago

I actually saw it and just forgot to run our sync from our internal repo to external. Doing that now!