Prepare for --incompatible_load_java_rules_from_bzl in Bazel 1.2.1

cpovirk commented 4 years ago

See https://github.com/google/flogger/issues/122, which I believe indicates a problem in bazel-common.

cpovirk commented 4 years ago

It looks like we may be stuck until there's a Bazel release that contains https://github.com/bazelbuild/bazel/issues/10046 ? But I think I've made some progress on the changes in Bazel and Flogger (https://github.com/google/flogger/issues/122) themselves.

cpovirk commented 4 years ago

For my reference:

I edited the Dagger WORKSPACE file to make google_bazel_common a local_repository instead of an http_archive. (In other news: Oops, I have been working against Dagger instead of Flogger. I suspect that both will ultimately need some direct changes (in addition to the changes to pick up my edits to bazel_common), even though I don't see a Dagger bug about this problem yet. I guess I should start on Flogger soon.)
I ran buildifier --lint=fix -warnings=native-java -r . but then had to go back and change the new load() statements from //third_party/bazel_rules/rules_java/java:defs.bzl to @rules_java//java:defs.bzl. Or at least I think that's what I needed to do. [edit: git diff --name-only master | xargs perl -pi -e "s'//third_party/bazel_rules/rules_java/java:defs.bzl'@rules_java//java:defs.bzl'"]

cpovirk commented 4 years ago

P3 because of the blockage on Bazel.

google / bazel-common