search

google / bazel_rules_install

Bazel rules for installing build results. Similar to `make install`.
Apache License 2.0
37 stars 14 forks source link

macOS support #37

Closed paulcacheux closed 7 months ago

paulcacheux commented 1 year ago

Sadly macOS binutils are similar but different:

For example the install tool on macOS does not support using -- to separate options from positional arguments. This PR checks if the source starts with - and skips the -- if not required.

Please note I would happy to edit this PR to implements another way of skipping the --. Maybe checking if we are on darwin or something else. Open to suggestions !

This PR also adapts the test script to support macOS, and adds a macOS workflow to the test github actions.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

hzeller commented 1 year ago

What is the status here ?

paulcacheux commented 1 year ago

Hello :wave: I was playing with this a bit, but I ended up not needing it in the end, feel free to take over the PR if you need it

hzeller commented 1 year ago

Did it work for you ? I don't have a mac to test, but I am using this project in another project to install things, and my Mac users would be happy if it would work :)

paulcacheux commented 7 months ago

Closing this since I won't be able to merge it