google / benchmark

A microbenchmark support library
Apache License 2.0
8.95k stars 1.62k forks source link

add compiler to build-and-test and create min-cmake CI bot #1550

Closed dmah42 closed 1 year ago

dmah42 commented 1 year ago

Related to #1544 Inspired by #1548

I noticed when adding the new min-cmake CI bot that we didn't actually set the compiler correctly for g++ and clang++ any more. let's see how much this breaks.

coryan commented 1 year ago

You can use Ninja as a generator on Windows too. It may require downloading and installing Ninja for windows. It has pre-compiled binaries:

https://github.com/ninja-build/ninja/releases

You may also consider a less full matrix in your testing. In other projects we do not test all the different combinations of OS, distro, build tools, compiler versions, compiler settings, etc. We test the oldest and newest version of each dimension in at least one build. Also consider that on Windows it is unlikely that folks are going to use CMake==3.10. That is more realistic for a Linux distro that ships with an specific version of CMake.

dmah42 commented 1 year ago

You can use Ninja as a generator on Windows too. It may require downloading and installing Ninja for windows. It has pre-compiled binaries:

https://github.com/ninja-build/ninja/releases

i can. our users do not.

You may also consider a less full matrix in your testing. In other projects we do not test all the different combinations of OS, distro, build tools, compiler versions, compiler settings, etc.

i'm not sure that reducing the coverage of our CI bots is the correct response to "this doesn't work in some CI bots".

We test the oldest and newest version of each dimension in at least one build. Also consider that on Windows it is unlikely that folks are going to use CMake==3.10. That is more realistic for a Linux distro that ships with an specific version of CMake.

that's fair. as the policy says only that the newest version of Windows is supported i can drop that section from this workflow.

dmah42 commented 1 year ago

failures are unrelated