google / benchmark

A microbenchmark support library
Apache License 2.0
8.69k stars 1.59k forks source link

[FR] Provide public accessors to benchmark name and arguments #1551 #1563

Closed gatorfax closed 1 year ago

gatorfax commented 1 year ago

https://github.com/google/benchmark/issues/1551

gatorfax commented 1 year ago

only fails with VS'19 release build?

https://github.com/google/benchmark/actions/runs/4377778378/jobs/7661688230#step:7:5141

65: BM_Complexity_O_N/2048         D:\a\benchmark\benchmark\test\output_test_helper.cc:115: internal::`anonymous-namespace'::CheckCase: Check `TC.match_rule != MR_Next' failed. Expected line "BM_Complexity_O_N_log_N_RMS                       11 %            86 %    " to match regex "^%rms_name %rms %rms[ ]*$"
65:     actual regex string "^BM_Complexity_O1_RMS [ ]*[0-9]+ % [ ]*[0-9]+ %[ ]*$"
65:     started matching near: BM_Complexity_O_N_log_N_RMS                       11 %            86 %    
65/74 Test #65: complexity_benchmark .......................Exit code 0xc0000409
***Exception:   2.11 sec

any ideas?

dmah42 commented 1 year ago

only fails with VS'19 release build?

https://github.com/google/benchmark/actions/runs/4377778378/jobs/7661688230#step:7:5141

65: BM_Complexity_O_N/2048         D:\a\benchmark\benchmark\test\output_test_helper.cc:115: internal::`anonymous-namespace'::CheckCase: Check `TC.match_rule != MR_Next' failed. Expected line "BM_Complexity_O_N_log_N_RMS                       11 %            86 %    " to match regex "^%rms_name %rms %rms[ ]*$"
65:     actual regex string "^BM_Complexity_O1_RMS [ ]*[0-9]+ % [ ]*[0-9]+ %[ ]*$"
65:     started matching near: BM_Complexity_O_N_log_N_RMS                       11 %            86 %    
65/74 Test #65: complexity_benchmark .......................Exit code 0xc0000409
***Exception:   2.11 sec

any ideas?

i think we have a test that gets optimized out so instead of being O(N log(N)) it ends up looking like constant time. it's not a critical test to pass so i'm happy to wave it through.