Fix build break with nvc++ when -Werror is ON

google / benchmark

A microbenchmark support library

Apache License 2.0

8.69k stars 1.59k forks source link

Fix build break with nvc++ when -Werror is ON #1569

Closed HFTrader closed 1 year ago

HFTrader commented 1 year ago

Build breaks when -Werror is turned on because of unhandled cases of inocuous/pedantic warnings. Adopted the same solution as for Intel PGI compiler - just disable -Werror manually, unless BENCHMARK_FORCE_WERROR is enabled. Fixes #1556.

HFTrader commented 1 year ago

Just realized I fixed through CMake but did not think about Bazel.

dmah42 commented 1 year ago

Just realized I fixed through CMake but did not think about Bazel.

i think we don't have as many flags in bazel so it's probably fine.