search

google / benchmark

A microbenchmark support library
Apache License 2.0
8.94k stars 1.62k forks source link

Remove not needed msan implementation from workflows #1587

Closed Zzzabiyaka closed 1 year ago

Zzzabiyaka commented 1 year ago

Hi team,

As msan is not currently used and probably is not expected to be used in the near future I'm suggesting to remove this build step what will make the pipeline log easier to read and will remove one unneded step.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

dmah42 commented 1 year ago

there's a TODO a few lines above. it is intended to be used once someone has time to look at why it's currently failing.

LebedevRI commented 1 year ago

The libc++ that is being used for msan build, is it built with msan sanitization itself? (can you point me at said failure?)

dmah42 commented 1 year ago

The libc++ that is being used for msan build, is it built with msan sanitization itself? (can you point me at said failure?)

https://github.com/google/benchmark/pull/1589