Add -Wsign-conversion to cmake and BUILD files

google / benchmark

A microbenchmark support library

Apache License 2.0

8.94k stars 1.62k forks source link

Closed oontvoo closed 1 year ago

LebedevRI commented 1 year ago

Isn't it -Wsign-conversion?

dmah42 commented 1 year ago

Isn't it -Wsign-conversion?

gcc: error: unrecognized command-line option '-Wsign_conversion'; did you mean '-Wsign-conversion'? :)

oontvoo commented 1 year ago

oops - my bad!

oontvoo commented 1 year ago

Ok - some tests are failing due to the new warnings (yay!) Updating them now - pls hold off reviewing

LebedevRI commented 1 year ago

It seems this got swapped out. Let's reopen this when needed.