google / benchmark

A microbenchmark support library
Apache License 2.0
8.61k stars 1.57k forks source link

Fix pass rvalue to DoNotOptimize #1608

Closed bgaifullin closed 1 year ago

bgaifullin commented 1 year ago

Fixes #1584

bgaifullin commented 1 year ago

windows build failed with error

Visual C++ build tools seems to be installed at C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC 
But Bazel can't find the following tools: 
    VCVARSALL.BAT, cl.exe, link.exe, lib.exe, ml64.exe 
for x64 target architecture 

seems like it does not related to current PR

dmah42 commented 1 year ago

windows build failed with error

Visual C++ build tools seems to be installed at C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC 
But Bazel can't find the following tools: 
    VCVARSALL.BAT, cl.exe, link.exe, lib.exe, ml64.exe 
for x64 target architecture 

seems like it does not related to current PR

that looks suspiciously like github changed something in the windows image.

dmah42 commented 1 year ago

windows build failed with error

Visual C++ build tools seems to be installed at C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC 
But Bazel can't find the following tools: 
    VCVARSALL.BAT, cl.exe, link.exe, lib.exe, ml64.exe 
for x64 target architecture 

seems like it does not related to current PR

that looks suspiciously like github changed something in the windows image.

https://github.com/actions/runner-images/issues/7662 may be related

bgaifullin commented 1 year ago

@dmah42 How to restart checks (seems like issue for windows has been resolved) ?

dmah42 commented 1 year ago

@dmah42 How to restart checks (seems like issue for windows has been resolved) ?

i've restarted them.

dmah42 commented 1 year ago

still failing, but i'm comfortable that a) it's an issue we can't do much about and b) unlikely to be an issue based on your PR.

LebedevRI commented 1 year ago

@bgaifullin thank you! While we are at it, could you please add a test so this does not get re-broken, please?

bgaifullin commented 1 year ago

The windows build still failing with error about missing compiler binary. ((

LebedevRI commented 1 year ago

@dmah42 can the failing CI runs be un-required?

dmah42 commented 1 year ago

thank you!