search

google / benchmark

A microbenchmark support library
Apache License 2.0
8.61k stars 1.57k forks source link

Add support for bzlmod (excluding Python bindings) #1615

Closed macandy13 closed 1 year ago

macandy13 commented 1 year ago

This is the first part of migrating google_benchmark to support bzlmod, the new module dependency management system. This part of the migration focuses on migrating all targets in //:all, //tools:all. It excludes the //bindings/.. targets for now, as those are depending on some changes in rules_python.

Overarching issue: https://github.com/bazelbuild/bazel-central-registry/issues/384

dmah42 commented 1 year ago

is there anything we need to do with the github action bots?

macandy13 commented 1 year ago

Sorry for the delay, was ooo for the last days.

Good point about the github actions. I think we should at least have a single environment in which we run with the --enable_bzlmod flag being set so this won't break in the future. Will take a look at it soon.