search

google / benchmark

A microbenchmark support library
Apache License 2.0
8.61k stars 1.57k forks source link

Add more terminals with color support #1620

Closed ii14 closed 1 year ago

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ii14 commented 1 year ago

Looks like CLA requires a Google account. Is it really necessary for such a tiny change?

dmah42 commented 1 year ago

https://cla.developers.google.com/about

i'm afraid we do need CLAs for any contributions, and our CLA does require a Google account.

ii14 commented 1 year ago

Maybe I'll figure this out some other day then. In the meantime, if anyone wants to, feel free to apply this patch under your own name as the author.

ii14 commented 1 year ago

Superseded by #1621