search

google / benchmark

A microbenchmark support library
Apache License 2.0
8.94k stars 1.62k forks source link

Increase the kMaxIterations limit #1668

Closed andreas-abel closed 11 months ago

andreas-abel commented 1 year ago

This pull request fixes #1663. Note that as a result of this change, the columns in the console output can become misaligned if the actual iteration count is too high. This will be dealt with separately (see also #1664).

dmah42 commented 1 year ago

Assertion failed: iters > i.iters && "if we did more iterations than we want to do the next time, " "then we should have accepted the current iteration run.", file src/benchmark_runner.cc, line 444

in the bazel windows run.

dmah42 commented 11 months ago

approved, but there's more lint errors i think.

andreas-abel commented 11 months ago

It looks like the other lint error actually comes from this PR: https://github.com/google/benchmark/pull/1681

I think it should be fixed there.

dmah42 commented 11 months ago

It looks like the other lint error actually comes from this PR: #1681

I think it should be fixed there.

that's been merged and didn't have a lint issue.. maybe try updating this branch to head?

andreas-abel commented 11 months ago

Actually, it looks like the other one does have this issue, even though it was merged: https://github.com/google/benchmark/actions/runs/6535161131/job/17744142279

dmah42 commented 11 months ago

oh woops. i thought i had lint set as a required CI. i'll fix that separately then.

LebedevRI commented 11 months ago

oh woops. i thought i had lint set as a required CI. i'll fix that separately then.

Oops...

dmah42 commented 11 months ago

thank you!

LebedevRI commented 11 months ago

thank you!