Closed Maetveis closed 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I don't think the sanitizer builds failing are relevant, this shouldn't change anything on Linux and all windows jobs pass.
I don't think the sanitizer builds failing are relevant, this shouldn't change anything on Linux and all windows jobs pass.
agreed. filed https://github.com/google/benchmark/issues/1670
There are three major compilers on Windows targeting the MSVC ABI (i.e. linking with microsofts STL etc.):
MSVC
clang-cl
aka clang with the MSVC compatible CLIclang++
aka clang with gcc compatible CLIThe cmake variable
MSVC
is only set for the first two as it defined in terms of the CLI interface provided:(from cmake docs)
For many of the checks in the library its the ABI that matters not the cmdline, so check
CMAKE_CXX_SIMULATE_ID
too, if it isMSVC
the current compiler is targeting the MSVC ABI. This handlesclang++
Fixes: #1597