search

google / benchmark

A microbenchmark support library
Apache License 2.0
8.93k stars 1.62k forks source link

Fix `pre-commit` GitHub Actions job #1708

Closed nicholasjng closed 9 months ago

nicholasjng commented 10 months ago

For some reason, editable pip installs are now broken, which means that they will break the pre-commit workflow due to the pip install -e . instruction.

Since the normal install is unaffected, we can just drop the -e switch. It does not matter which mode is used, since the environment is only used for linting.

I debugged a little bit, and found the reason why editable installs do not work right now - I just have not figured out a way to change the Bazel extension class to do the right thing yet. (Debugging setuptools is not nice, since a lot of the package is stub files, and each entry point loads a different command).

nicholasjng commented 9 months ago

Test failure (timeout in gtest) seems to be a flake?

dmah42 commented 9 months ago

Test failure (timeout in gtest) seems to be a flake?

rerunning to confirm.