search

google / benchmark

A microbenchmark support library
Apache License 2.0
8.93k stars 1.62k forks source link

Enable Large-file Support #1726

Closed oToToT closed 9 months ago

oToToT commented 9 months ago

This should fix https://github.com/google/benchmark/issues/1725

dmah42 commented 9 months ago

i'm not sure how necessary this is (see my comment on #1725 ) but if we do need it please also add these definitions to the bazel build.

dmah42 commented 9 months ago

i don't know what the pre-commit failure means or why it's an issue that the bazel file has changed in an expected way. maybe do what it says (pre-commit run --all-files).

perhaps some file is being generated based on the BUILD.bazel?

oToToT commented 9 months ago

Looks like I accidentally use tabs instead of whitespaces as indent. It should be fixed now.

dmah42 commented 9 months ago

thanks!