search

google / benchmark

A microbenchmark support library
Apache License 2.0
8.59k stars 1.57k forks source link

Revert "fix some warnings" #1762

Closed LebedevRI closed 3 months ago

LebedevRI commented 3 months ago

This reverts commit 1576991177ba97a4b2ff6c45950f1fa6e9aa678c.

dmah42 commented 3 months ago

but why? i had local compiler warnings due to potential size differences.

LebedevRI commented 3 months ago

but why? i had local compiler warnings due to potential size differences.

Because the CI was green before that change, and went red after that change. I think branch protection rules are wrong, they either prevent everyone from bypassing them, or nobody.

dmah42 commented 3 months ago

but why? i had local compiler warnings due to potential size differences.

Because the CI was green before that change, and went red after that change. I think branch protection rules are wrong, they either prevent everyone from bypassing them, or nobody.

oh right. that's fair.

LebedevRI commented 3 months ago

@dmah42 thank you! I'm sure the whatever diagnostics those changes were trying to address can be addressed without reintroducing that breakage.