google / benchmark

A microbenchmark support library
Apache License 2.0
8.93k stars 1.61k forks source link

[FR] Remove COMPILER_IBMXL macro for z/OS #1776

Closed fanbo-meng closed 5 months ago

fanbo-meng commented 6 months ago

Is your feature request related to a problem? Please describe. COMPILER_IBMXL is no longer needed to distinguish compilers on z/OS.

Describe the solution you'd like Remove the macro definition and usage.

Describe alternatives you've considered N/A

Additional context N/A

LebedevRI commented 6 months ago

Is your feature request related to a problem? Please describe. COMPILER_IBMXL is no longer needed to distinguish compilers on z/OS.

Why?

fanbo-meng commented 6 months ago

I added COMPILER_IBMXL to identify the Clang based IBM XL compiler (xlclang) on z/OS. This compiler is obsolete and replaced by the Open XL compiler, so the macro is no longer needed and the existing code would lead to incorrect asm syntax for Open XL. Please review https://github.com/google/benchmark/pull/1777

LebedevRI commented 6 months ago

That wording needs to be in the commit message of that PR

fanbo-meng commented 5 months ago

closed by https://github.com/google/benchmark/pull/1777