search

google / benchmark

A microbenchmark support library
Apache License 2.0
8.59k stars 1.57k forks source link

Remove COMPILER_IBMXL macro for z/OS #1777

Closed fanbo-meng closed 2 months ago

fanbo-meng commented 3 months ago

This patch removes definition and usage of COMPILER_IBMXL macro, resolves issue https://github.com/google/benchmark/issues/1776

LebedevRI commented 2 months ago

I'm guessing that ecosystem/hardware is so special we (well, you) get to dictate that said obsolete compiler is simply completely unsupported going forward, and thus such change is fine?

dmah42 commented 2 months ago

thanks. and thanks for the commit description :)

fanbo-meng commented 2 months ago

I'm guessing that ecosystem/hardware is so special we (well, you) get to dictate that said obsolete compiler is simply completely unsupported going forward, and thus such change is fine?

Yes I'm from the dev team of z/OS C/C++ compiler. That macro isn't used anywhere else other than the one instance in cycleclock.h, and after this change the code would still compile the same way (for that compiler). Thus IMHO we aren't exactly removing support and this change is fine.

LebedevRI commented 2 months ago

Yup, thank you, i just wanted that to be explicitly stated. Thank you!