Closed kraj closed 1 month ago
The cast should be on the outside, shifting signed values is generally not recommended.
thats right.
Looks like clang-format isn't happy
Looks like clang-format isn't happy
yeah. Fixed in v3, hopefully
@kraj thank you for the contribution!
fixes build with clang19
src/cycleclock.h:208:52: error: implicit conversion changes signedness: 'uint64_t' (aka 'unsigned long long') to 'int64_t' (aka 'long long') [-Werror,-Wsign-conversion] 208 | return (static_cast(cycles_hi1) << 32) | cycles_lo;
|
~~~~~~~~~~^~~~~ 1 error generated.