search

google / bigwheels

BigWheels is a cross-platform, API agnostic framework to build graphics applications.
Apache License 2.0
94 stars 37 forks source link

Geometry death tests fail on some platforms #496

Closed s-perron closed 4 months ago

s-perron commented 4 months ago

The death tests added in https://github.com/google/bigwheels/pull/490 are failing because the string does not match correctly.

https://github.com/google/bigwheels/blob/8bb848be3cec90a1608efa0c452d5a65afc23a88/src/test/geometry_test.cpp#L71

Since the string does not change any real content, could we change it to "" like all of the other death tests?

footballhead commented 4 months ago

Makes sense to me, the death is the thing that I'm testing (not the contents of the message).