search

google / bindiff

Quickly find differences and similarities in disassembled code
https://zynamics.com/bindiff.html
Apache License 2.0
2.22k stars 136 forks source link

Manual matching does not trigger diff #10

Open cblichmann opened 1 year ago

cblichmann commented 1 year ago

Steps to reproduce the problem:

  1. Unmatch blocks.
  2. Match blocks.
  3. Observe that all text is different. See gif and image.

What is the expected behavior? Text is diffed properly.

What went wrong? Text is marked as different.

What version of the product are you using? On what operating system? BinDiff 6, Win10.

177788191__32168413__191454

177788191__32168414__191454

Ported from b/177788191

cblichmann commented 1 year ago

This is a shortcoming of the UI. Ideally, the action shown in your video would trigger a re-diff of the function in question. But since we only have a one-way communication between the UI and the BinDiff engine, all the UI does is kind of a best-effort match/unmatch.

The actual textual diff is correct in a way, as the addresses are different on both sides. But I agree that we can to better here.