UI: Font-Family Should be configable

google / bindiff

Quickly find differences and similarities in disassembled code

https://zynamics.com/bindiff.html

Apache License 2.0

2.15k stars 130 forks source link

UI: Font-Family Should be configable #22

Open tylzh97 opened 11 months ago

tylzh97 commented 11 months ago

Describe the bug Some characters are not displayed properly. Because bindiff trying to use Roboto Mono as the only font, However this font family doesn't support non-ASCII characters. Maybe font-family config can be add into config>main settings>general card.

To Reproduce Just Open it and open any config window.

Screenshots

Environment (please complete the following information):

OS and version: Windows 10
Locale: zh-CN (Simplified Chinese)
Disassembler and version: IDA Pro 7.1

Additional context Add any other context about the problem here.

cblichmann commented 11 months ago

Oh wow. Sorry for that. We really only support (and test) US English as the locale.

As a workaround, try setting the font in the config file (in %AppData%\Roaming\BinDiff\bindiff.json):

Setting this to "Segoe UI" for example, works for setting the UI font, but the core problem is that the Java runtime does not have a concept of fallback fonts if characters needed for a locale are not available.

Setting the font to "SimSun" looks ugly for western text, but seems to work (I don't know any Chinese...):

tylzh97 commented 11 months ago

Thanks very much! It works for me. And may I ask are there any plans to include font configuration in the configuration menu in a future release?

cblichmann commented 11 months ago

I don't see why not. It'd be good to revamp the settings dialog anyways.