google / bindiff

Quickly find differences and similarities in disassembled code

https://zynamics.com/bindiff.html

Apache License 2.0

2.15k stars 130 forks source link

Make IDA an optional dependency #27

Closed pratikpc closed 7 months ago

pratikpc commented 10 months ago

This fix works by making find_package(IdaSdk) into an optional dependency.

For every CMake find_package call, CMake creates a PackageName_FOUND variable.

The same variable can be checked when the add_subdirectory command is being called.

TODO: Documenting in the README could use some work

Closes #26

Note

Need some help with testing the codebase as I don't have access to IDA myself.
But theoretically, the code here should work.

google-cla[bot] commented 10 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

cblichmann commented 7 months ago

Sent for internal review, thanks!