search

google / binexport

Export disassemblies into Protocol Buffers
Apache License 2.0
1.03k stars 197 forks source link

[Ghidra] BinExport should never export multiple functions at the same address #76

Open cblichmann opened 3 years ago

cblichmann commented 3 years ago

When exporting the busybox binary from busybox_mips_ghidra_binexport.zip, the function _init at address 004028B0 is included twice in the flow_graph field, causing BinDiff to fail:

$ bindiff busybox_g.BinExport busybox_g.BinExport 
BinDiff 7 (@376216480, May 27 2021), (c)2004-2011 zynamics GmbH, (c)2011-2021 Google LLC.
Error: AttachFlowGraph: flow graph already attached 004028B0

The root cause is Ghidra not properly handling _init, but the BinExport extension should always output a valid .BinExport.

cblichmann commented 3 years ago

For reference: BinDiff b/153891410.

nstarke commented 3 years ago

FWIW this issue seems specific to MIPS binaries - I had the same problem with MIPS eCos images.

Is there any known work around for this? Thanks in advance

cblichmann commented 3 years ago

Well, BinExport uses whatever the disassembler gives it. So on one hand, this should really be fixed in Ghidra, either by fixing its analysis/heuristics or manually by cleaning up the disassembly. A small script that highlights duplicate functions should be easy enough to come up with for this. On the other hand, like I already said above, BinExport should always produce a valid .BinExport file. So I will fix this in BinExport, too, at some point. But that likely means to just drop one duplicated functions. This may or may not be what you'd want, though, as we might drop the wrong one (and for BinExport there's no way to know which one is good).

nstarke commented 3 years ago

Thank you for taking the time to respond to my question. I appreciate it.

janbbeck commented 1 year ago

I just want to bump this with a little additional information: I have the same problem with an ARM executable, so this is not restricted to MIPS

janbbeck commented 1 year ago

Oh, and I should point out that this happens when comparing 2 debug builds of closely related executables. Seems strange for Ghidra to get tripped up on that...

Martmists-GH commented 1 year ago

Encountered this same issue on AARCH64 binaries, still an issue on latest version.