search

google / binexport

Export disassemblies into Protocol Buffers
Apache License 2.0
1.05k stars 206 forks source link

Correction to Windows VS2019 build instructions #94

Closed throwaway-a closed 2 years ago

throwaway-a commented 2 years ago 
cmake .. ^
    -G "Visual Studio 16 2019 Win64" ^
...

yields

CMake Error: Could not create named generator Visual Studio 16 2019 Win64

Generators
  Visual Studio 17 2022        = Generates Visual Studio 2022 project files.
                                 Use -A option to specify architecture.
* Visual Studio 16 2019        = Generates Visual Studio 2019 project files.
                                 Use -A option to specify architecture.
  Visual Studio 15 2017 [arch] = Generates Visual Studio 2017 project files.
                                 Optional [arch] can be "Win64" or "ARM".
...

So it looks like the "Win64" is no longer needed for the VS2019-targeting instructions.

aaaand...I got to the end of the instructions for how to build from source for Windows...and then it was stated what to do for Ghidra, only for IDA and BinaryNinja... So was I mistaken and build from source is not possible? (In which case I guess I'd be referring back to this ticket and now asking for an updated version for 10.1.4, since the latest BinDiffHelper is available for...)

Lesser priority misc: I was confused briefly into thinking I needed to somehow get IDA SDK even though I was compiling for Ghidra. So it'd be good if there were a minor comment there indicating that the section is only needed if building specifically for IDA. (Similarly the "To disable the IDA Pro build..." command later is only read after one has theoretically already run the command, so it'd be nice if the IDA/BinaryNinja caveats were moved ahead of the commands, because I have a tendency to simply run the commands I'm told, in the order in which they appear, not read the entire section before running commands...)

There's one missed copy-paste error where it says "Shown commands are for IDA 7.5:" even though the commands were updated to be for 7.6.

cblichmann commented 2 years ago

Thanks, I created a change to fix the documentation issue.

So was I mistaken and build from source is not possible?

Building from source is possible :) - the instructions for Ghidra are in /java. The reason this is a bit confusing is that I started the Ghidra exporter way later and didn't update the main instructions to reflect that well. That and at Google, we tend to organize open source code by putting C++ first, then have sub-directories for other languages.

[...] because I have a tendency to simply run the commands I'm told, in the order in which they appear, not read the entire section before running commands

I know, right? I have a similar problem with following cooking recipes and always get annoyed when they mention "leave to rest overnight in the fridge" about halfway through it... :-D