search

google / bloaty

Bloaty: a size profiler for binaries
Apache License 2.0
4.71k stars 340 forks source link

Support DW_FORM_implicit_const and DW_FORM_line_strp. #299

Closed ta-makino closed 2 years ago

ta-makino commented 2 years ago

It looks like the first instance of implicit_const got added to LLVM recently: https://github.com/llvm/llvm-project/commit/12f80c0bbda2b1492f521345b287343457ccd03c Also recent g++ emits DW_FORM_line_strp (confirmed with g++ 11.2.0). This change changes bloaty to safely skip these DWARF forms.

FIXES=202984448

haberman commented 2 years ago

Thank you for the PR. Would you be able to put the test case in yaml2obj form in https://github.com/google/bloaty/tree/master/tests/dwarf/debug_info

The new yaml2obj-based tests are more robust and easier to modify.