search

google / bloaty

Bloaty: a size profiler for binaries
Apache License 2.0
4.71k stars 340 forks source link

build: add a missing dependency on capstone for libbloaty #327

Closed compnerd closed 1 year ago

compnerd commented 1 year ago

libbloaty depends on capstone (at least in disassembler.cc). Use target_link_libraries to indicate that libbloaty should link against capstone which will also ensure that we have the proper header search path for the capstone headers and that capstone is a build dependency for libbloaty. This should hopefully avoid a latent build race that was uncovered in #325.

haberman commented 1 year ago

This appears to cause a build error on Windows.

compnerd commented 1 year ago

This was an incorrect analysis, and the workaround for this is squashed into #326