search

google / bloaty

Bloaty: a size profiler for binaries
Apache License 2.0
4.66k stars 337 forks source link

Fix incorrect comparison #341

Closed nick-potenski closed 1 year ago

nick-potenski commented 1 year ago

Fixes #208, which notes in its comments that the integer overflow comparison was using an incorrect numeric limit for half of the check. It looks like this was a copy/paste error when CheckAdd() was updated to support other types besides integers by bd5630bf5fb1124b2652a9302a98601be9325516.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.