search

google / bloaty

Bloaty: a size profiler for binaries
Apache License 2.0
4.77k stars 345 forks source link

Fix various issues with debug_lines parsing, and support DWARF5 #383

Open peadar opened 2 months ago

peadar commented 2 months ago

This fixes '-d inlines' support for ELF, and also allows it work with DWARF5 - fixes #311

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

peadar commented 2 months ago

CLA issues should be sorted - any opinions on this?

haberman commented 2 months ago

Thanks for the fixes. If possible, it would be really helpful to add yaml2obj tests. We don't currently have any for debug_lines, but it would be great to add some: https://github.com/google/bloaty/tree/main/tests/dwarf

peadar commented 2 months ago

Sure, let me take a look