google / blockly-android

Blockly for Android
Apache License 2.0
671 stars 209 forks source link

Adding DefaultBlocks, constants related to the default/playground blocks #574

Closed AnmAtAnm closed 7 years ago

AnmAtAnm commented 7 years ago

This change is Reviewable

RoboErikG commented 7 years ago

:lgtm: couple missing TODOs


Review status: 0 of 9 files reviewed at latest revision, 2 unresolved discussions.


blocklylib-core/src/main/java/com/google/blockly/model/DefaultBlocks.java, line 64 at r1 (raw file):

    public static Map<String, BlockExtension> getExtensions() {
        if (DEFAULT_EXTENSIONS == null) {
            Map<String, BlockExtension> temp = new ArrayMap<>();

TODO?


blocklylib-core/src/main/java/com/google/blockly/model/DefaultBlocks.java, line 77 at r1 (raw file):

    public static Map<String, Mutator.Factory> getMutators() {
        if (DEFAULT_MUTATORS == null) {
            Map<String, Mutator.Factory> temp = new ArrayMap<>();

Ditto


Comments from Reviewable