search

google / blockly-android

Blockly for Android
Apache License 2.0
671 stars 209 forks source link

Remove unused deprecated methods #593

Closed RoboErikG closed 7 years ago

RoboErikG commented 7 years ago

We'd deprecated a few methods which were replaced by preferred versions. Most of these methods are now unused, so this CL removes them. One method is only used in testing by its specific test class and was made package private. There is one remaining deprecated method that is used in testing outside its package.

This change is Reviewable

AnmAtAnm commented 7 years ago

I left all of these in because we don't know what our users are using. Particularly the old form of obtainBlock().

RoboErikG commented 7 years ago

As discussed offline, I took another pass at these and also cleaned up the two copies of test_blocks.json.

Review status: 0 of 20 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

AnmAtAnm commented 7 years ago
:lgtm:

Reviewed 20 of 20 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable