search

google / blockly-android

Blockly for Android
Apache License 2.0
671 stars 209 forks source link

Fix bug around creating 'item' variable randomly #600

Closed RoboErikG closed 7 years ago

RoboErikG commented 7 years ago

Also fixes a bug with deleting the last variable while the flyout is open on the variables category.

Fixes #500

This change is Reviewable

AnmAtAnm commented 7 years ago

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

blocklylib-core/src/main/java/com/google/blockly/model/VariableCategoryFactory.java, line 93 at r1 (raw file):

            return;
        }
        ArrayList<String> varNames = new ArrayList<>(variables.size());

Nit: Maybe SortedSet like TreeSet? (trading short term memory for readability of intent)

Comments from Reviewable

AnmAtAnm commented 7 years ago
:lgtm:

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

RoboErikG commented 7 years ago

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

blocklylib-core/src/main/java/com/google/blockly/model/VariableCategoryFactory.java, line 93 at r1 (raw file):

Previously, AnmAtAnm (Andrew n marshall) wrote…
Nit: Maybe SortedSet like TreeSet? (trading short term memory for readability of intent)

Done.

Comments from Reviewable