google / blockly-android

Blockly for Android
Apache License 2.0
671 stars 209 forks source link

#675 Allow gridColor, gridSpacing and gridDotColor #680

Closed ChrisCanCompute closed 6 years ago

ChrisCanCompute commented 6 years ago

gridColor, gridSpacing and gridDotColor can all be set as attributes on a WorkspaceFragment.

(I haven't added backgroundColor, but it should be reasonably straightforward from here if someone else wants to pick that up).


This change is Reviewable

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


ChrisCanCompute commented 6 years ago

I've just signed the CLA using my new email address.

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot commented 6 years ago

CLAs look good, thanks!

ChrisCanCompute commented 6 years ago

Resubmitted with my personal email address (using my work laptop, but developing on my own time).

AnmAtAnm commented 6 years ago

Awesome. Thanks again, Chris!