Closed ChrisCanCompute closed 6 years ago
I'll look into the failing tests.
Thanks. I was lazy when writing these. It would be great if there was a function call for these, though I know that would incur the call overhead for something that should really never happen. Fix up the line lengths and I'll pull this in.
Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.
blocklylib-core/src/main/java/com/google/blockly/android/ui/fieldview/BasicFieldAngleView.java, line 43 at r1 (raw file):
public void onValueChanged(Field angleField, String oldValue, String newValue) { if (BuildConfig.DEBUG && !(angleField == mAngleField)) { throw new AssertionError(String.format("angleField (%s) must match mAngleField (%s)",
line length should be 100 chars
blocklylib-core/src/main/java/com/google/blockly/model/BlockTemplate.java, line 438 at r1 (raw file):
BlockTemplate withFieldValue(String fieldName, String value) { if (BuildConfig.DEBUG && (TextUtils.isEmpty(fieldName) || TextUtils.isEmpty(value))) { throw new AssertionError(String.format("Neither fieldName (%s) nor value (%s) may be blank",
line length should be 100 chars
Comments from Reviewable
The travis breakage is the usual #653 flakiness unrelated to this change.
Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.
Comments from Reviewable
Assertions are unreliable in Dalvik and unimplemented in ART. Use BuildConfig.DEBUG conditional checks instead.
This change is![Reviewable](https://reviewable.io/review_button.svg)