google / blockly-android

Blockly for Android
Apache License 2.0
672 stars 209 forks source link

Add Padding To If/Else Mutator Dialog #738

Closed TheBrokenRail closed 5 years ago

TheBrokenRail commented 5 years ago

Fixes

Fixes #734

Changes

This adds padding using android's ?dialogPreferredPadding so it doesn't use any magic numbers and it fits with the dialog's style, I didn't do anything for top and bottom because I couldn't find any concrete numbers.


This change is Reviewable

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
TheBrokenRail commented 5 years ago

I Signed It!

googlebot commented 5 years ago

CLAs look good, thanks!