google / blockly-android

Blockly for Android
Apache License 2.0
672 stars 209 forks source link

Updating Gradle, build tools and dependencies. Using 'implementation' and/or 'api' instead of 'compile'. resolve #752 #753

Closed aidayounesi closed 5 years ago

aidayounesi commented 5 years ago

Gradle is now 3.2.1. Build tools are now 28.0.3. Updating supporting libraries to 28.0.0. All uses of 'compile' have been replaced with either 'implementation' or 'api', because 'compile' is deprecated, and needs to be replaced by the end of 2018 (Following the issues #724 #736 #737 #645 ). We used api mostly because "Gradle know that the module wants to transitively export that dependency to other modules, so that it's available to them at both runtime and compile time" here.


This change is Reviewable

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
aidayounesi commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

aidayounesi commented 5 years ago

resolve #752

AnmAtAnm commented 5 years ago

@aidayounesi Thank you for all the updates!