google / blockly-android

Blockly for Android
Apache License 2.0
672 stars 209 forks source link

fix: App crashed when replacing different types of blocks in input_connection #755

Closed mingway426 closed 5 years ago

mingway426 commented 5 years ago

modify: some code in BlocklyController.java & Connection.java

When the building block is replaced, it will be judged. If the newly generated connection is not empty and contains only one connectable input parameter, then the original intention is to connect the replaced building block to the new building block. However, there is no judgment on the type. If the type of the replaced block does not match the type required, the application will crash.


This change is Reviewable

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
mingway426 commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

mingway426 commented 5 years ago

resolve https://github.com/google/blockly-android/issues/754