search

google / blockly-android

Blockly for Android
Apache License 2.0
672 stars 209 forks source link

Use Gradle To Download Blockly Web Files & Add Other Lanuage Demos #757

Closed TheBrokenRail closed 5 years ago

TheBrokenRail commented 5 years ago

This makes sure when you build blockly-android you will always get the latest stable version of Blockly. It also gives examples if you want to generate for other languages.

This change is Reviewable

TheBrokenRail commented 5 years ago

Since this only downloads files if they aren't already downloaded, I would say requiring the internet is a non-issue, since you need to download the git repo anyway.

TheBrokenRail commented 5 years ago

You can add :lite@aar or :full@aar to your dependency line for JitPack or JCenter, to select flavor or keep as is to use the full version.

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

TheBrokenRail commented 5 years ago

Done!

TheBrokenRail commented 5 years ago

Ready to approve?

AnmAtAnm commented 5 years ago

After merging this, I'm getting the following error when building develop:

FAILURE: Build failed with an exception.

* What went wrong:
Task 'assembleDebug' not found in project ':blocklydemo'.

* Try:
Run gradle tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s