search

google / blockly-devtools

Tools for Blockly app developers to help build custom blocks.
http://developer.google.com/blockly
Apache License 2.0
60 stars 31 forks source link

Removing the top row of buttons in the WorkspaceEditor. #229

Closed AnmAtAnm closed 7 years ago

AnmAtAnm commented 7 years ago

Moved the shadow toggle buttons just above the editor workspace.

This change is Reviewable

svouse commented 7 years ago
:lgtm:

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

chynu commented 7 years ago
:lgtm:

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

src/view/workspace_editor_view.js, line 431 at r1 (raw file):

  </div>
  <section id="workspace_section">
    <div style="float: right">

Nit: I believe the <aside></aside> tags are right-floating (defined in factory.css).

Comments from Reviewable

AnmAtAnm commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

src/view/workspace_editor_view.js, line 431 at r1 (raw file):

Previously, chynu (celine choo) wrote…
Nit: I believe the `` tags are right-floating (defined in `factory.css`).

There is a semantic meaning to "aside" that doesn't apply here.

Comments from Reviewable

AnmAtAnm commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

src/view/workspace_editor_view.js, line 431 at r1 (raw file):

Previously, AnmAtAnm (Andrew n marshall) wrote…
There is a semantic meaning to "aside" that doesn't apply here.

(It doesn't apply to the preview, either, for that matter.)

Comments from Reviewable