Documentation V1 - Githubissues

chynu commented 7 years ago

First pass at usage instructions.

This change is

chynu commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

docs/README.md, line 14 at r1 (raw file):

* Build workspace contents (blocks that are loaded onto a Blockly workspace on
  load)
* Configure workspace inject options (currently a web-only feature).

Wondering if workspace configs are indeed a "web-only feature"? I'm just mimicking the old documentation here in this line.

Comments from Reviewable

AnmAtAnm commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

docs/README.md, line 14 at r1 (raw file):

Previously, chynu (celine choo) wrote…

Wondering if workspace configs are indeed a "web-only feature"? I'm just mimicking the old documentation here in this line.

Yep. Configuration is very different on the other platforms.

Comments from Reviewable

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

rachel-fenichel commented 7 years ago

One nit then lgtm.

AnmAtAnm commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

INSTRUCTIONS.md, line 73 at r2 (raw file):

Previously, rachel-fenichel (Rachel Fenichel) wrote…

libraries -> library

Done.

Comments from Reviewable

google / blockly-devtools

Documentation V1 #263